On Wednesday, November 14, 2012 6:04:11 AM UTC-6, Gavin Williams wrote:
>
> Ok, I've just pushed the latest code to Github:
> https://github.com/fatmcgav/fatmcgav-netapp/commit/d5ae999fc49b1de6726e8f4b7027648cf2eb64a2
>
> I've managed to get the *create *functioning correctly, and updating the
> NetApp options as required.
>
> *exists?* has also been fleshed out a lot.
> Logic is that it will pull back a list of the current options set against
> the referenced volume, and then construct a hash of the returned key=>value
> pairs.
> The matching keys are then pulled from the current options and the setting
> options hashes, and the values of those keys compared.
> If they are different, then the *create *should be triggered.
>
> This is working fine in principle.
>
> However the current issue is that the *exists?* will *return false*whenever a
> single property value doesn't match. The create will then
> process the whole list of setting options, rather than just the mis-matched
> one(s)...
>
Your design sounds flawed to me. I think you're getting tripped up by the
difference between modelling all the options as a group (as you are doing)
and modelling individual options. I'm not certain that it makes sense for *
exists?* ever to return false, for even an empty set of options is still a
set of options. If it never returns false then your *create* method will
never be called, so it can be empty.
Notably missing from your code, however, is a non-trivial implementation of
*options=*, the setter method for your main property. Puppet will invoke
that method at least if it finds that the target value assigned to the
resource differs from the actual value read from the provider. It would
normally be in that method that your provider does the actual work of
modifying the existing target resource (i.e. setting the options). If you
don't want to re-set all the options, then this would be a good place to
check what changed, and set only those.
>
> An example run gives:
>
> ^[[0;36mDebug^[[0m: Puppet::Provider::netapp_volume_options: Matched Name
>> no_atime_update. Current value = off. New value = on
>> ^[[0;36mDebug^[[0m: Puppet::Provider::netapp_volume_options:
>> no_atime_update values don't match.
>> ^[[0;36mDebug^[[0m: Puppet::Provider::Netapp_volume_options: setting
>> Netapp Volume options against volume v_puppet_test12111508.
>> ^[[0;36mDebug^[[0m: Puppet::Provider::Netapp_volume_options: Setting =
>> no_atime_update, Value = on
>> ^[[0;36mDebug^[[0m: Puppet::Provider::Netapp_volume_options: Volume
>> Option no_atime_update set against Volume v_puppet_test12111508.
>> ^[[0;36mDebug^[[0m: Puppet::Provider::Netapp_volume_options: Setting =
>> convert_ucode, Value = on
>> ^[[0;36mDebug^[[0m: Puppet::Provider::Netapp_volume_options: Volume
>> Option convert_ucode set against Volume v_puppet_test12111508.
>> ^[[0;36mDebug^[[0m: Puppet::Provider::Netapp_volume_options: Volume
>> Options set successfully against Volume v_puppet_test12111508.
>>
>
> This is based on a config of:
>
>>
>> netapp_volume_options { 'v_puppet_test12111508':
>> options => {'convert_ucode' => 'on', 'no_atime_update' =>
>> 'on'},
>> require => Netapp_volume['v_puppet_test12111508']
>> }
>>
>>
> *convert_ucode* should match, and *no_atime_update* obviously didn't...
>
> Any ideas?
>
> Haven't as yet done anything with *insync?* yet, as if I'm honest it
> slightly baffles me currently...
>
I'm not sure you need to do anything for insync?. I think Puppet by
default compares the actual property values (obtained from the provider via
their getter methods) with the ones set on the resource (as parsed from the
manifest), and considers the resource to be in sync if they all are equal.
John
--
You received this message because you are subscribed to the Google Groups
"Puppet Users" group.
To view this discussion on the web visit
https://groups.google.com/d/msg/puppet-users/-/9SBH1F9q4kIJ.
To post to this group, send email to puppet-users@googlegroups.com.
To unsubscribe from this group, send email to
puppet-users+unsubscr...@googlegroups.com.
For more options, visit this group at
http://groups.google.com/group/puppet-users?hl=en.
