On Thursday, September 6, 2012 4:48:40 PM UTC-5, Andreas Ntaflos wrote:
>
> On 2012-09-04 17:26, Bai Shen wrote:
> > I've gotten an install of solr working, but it's pretty much a hack job
> > at the moment. If y'all could give me your thoughts on how to improve
> > my setup, I'd appreciate it. apache-tomcat is an rpm of Tomcat 7 that
> > references the oracle jdk instead of openjdk.
>
> [...]
> > file { '/opt/apache-tomcat/conf/Catalina/localhost/solr.xml':
> > source => 'puppet:///modules/solr/solr.xml',
> > owner => 'tomcat',
> > group => 'tomcat',
> > mode => '644',
> > notify => Service['apache-tomcat'],
> > require => Package['apache-tomcat'],
> > }
>
> This would go into solr::config.
>
> It is better, IMHO, to use explicit dependencies here as well, i.e. not
> "notify" and "require", but something like this:
>
> Package['apache-tomcat']
> -> File['/opt/apache-tomcat/conf/Catalina/localhost/solr.xml']
> ~> Service['apache-tomcat']
>
> I guess that depends on your preferences.
>
Indeed, I would place that firmly in the category of style. Myself, I tend
to try to judge whether the relationship is inherent in the nature of the
resource (which is usually the case for me) vs. whether it's relevant only
to some larger context. I use resource parameters in the former case.
Admittedly, that's a pretty fuzzy distinction, but in the the example above
I personally would write the relationships just as the OP did.
John
--
You received this message because you are subscribed to the Google Groups
"Puppet Users" group.
To view this discussion on the web visit
https://groups.google.com/d/msg/puppet-users/-/Zu9wfujAyH4J.
To post to this group, send email to puppet-users@googlegroups.com.
To unsubscribe from this group, send email to
puppet-users+unsubscr...@googlegroups.com.
For more options, visit this group at
http://groups.google.com/group/puppet-users?hl=en.
