On Thu, May 24, 2012 at 1:53 PM, Tim Mooney <tim.moo...@ndsu.edu> wrote:
>
> All-
>
> We have several modules that have defines within them that the style guide
> (sections 11.1 & 11.4) and puppet-lint suggest should be in their own
> file. I'm working on fixing them and have a question about how things
> should be refactored.
>
> A stripped down example:
>
> The node:
>
> node 'foo.bar.edu' {
> include oracledb::instantclient
> }
>
>
> file modules/oracledb/manifests/instantclient.pp:
>
> class oracledb::instantclient($version='11.1') {
>
> include ldconfig
>
> # other non-relevant stuff here
>
> ldconfig::config { 'oracle-instantclient':
> content => template('oracledb/instantclient.ld.conf.erb'),
> }
>
> }
>
>
> file modules/ldconfig/manifests/init.pp:
>
> class ldconfig {
>
> exec { '/sbin/ldconfig':
> refreshonly => true,
> alias => 'ldconfig',
> }
>
>
> define config($content) {
> file { "/etc/ld.so.conf.d/${name}.conf":
> ensure => file,
> owner => 'root',
> group => 'root',
> mode => '0644',
> content => $content,
> notify => Exec['ldconfig'],
> }
> }
> }
>
>
> Note the define for config() within the init.pp for ldconfig. That's now
> out of favor. Moving that define into it's own file in
> modules/ldconfig/manifests/config.pp is straightforward, but it leaves
> me with questions about where the exec should be.
>
> - if I add a "requires => Class['ldconfig']" to the file within the
> config() define, I now have a circular dependency that puppet errors on.
>
> - if I don't include the "requires => Class['ldconfig']" but I'm careful
> to keep the "include ldconfig" in every class that also uses
> ldconfig::config, things "work", but that seems like the wrong way to
> do it, as it only works if I do both things, because of the implicit
> dependency on the exec.
I would say include 'ldconfig' in define ldconfig::config, then the
define is self contained, and you don't need remember include ldconfig
everywhere.
Thanks,
Nan
--
You received this message because you are subscribed to the Google Groups
"Puppet Users" group.
To post to this group, send email to puppet-users@googlegroups.com.
To unsubscribe from this group, send email to
puppet-users+unsubscr...@googlegroups.com.
For more options, visit this group at
http://groups.google.com/group/puppet-users?hl=en.
