Thanks for the suggestions, they are going to be merged.
That's a define I did various years ago that actually has been useful in
various cases (I do agree that it's better to use packages, but sometimes
this is the quickest and saner approach).
Al
On Wednesday, July 13, 2011 8:53:33 AM UTC+2, vagn wrote:
>
> On 07/12/2011 06:19 AM, Al @ Lab42 wrote:
> > command => "mkdir -p $destination_dir ; cd
> > $destination_dir ; $extract_command $work_dir/$source_filename",
> Nice. But I would suggest changing ';' to '&&'. That way, if the
> mkdir or cd fail you don't end up
> trying to extract the archive in the wrong directory.
>
> command => "mkdir -p $destination_dir && cd $destination_dir &&
> $extract_command $work_dir/$source_filename",
>
> Also consider
>
> unless => "test -d ${destination_dir }/${extracted_dir}",
>
> or even better
>
> creates => "${destination_dir }/${extracted_dir}",
>
> for the repetition guard.
>
> --
> vagn
>
>
--
You received this message because you are subscribed to the Google Groups
"Puppet Users" group.
To view this discussion on the web visit
https://groups.google.com/d/msg/puppet-users/-/EjT5lFqc31MJ.
To post to this group, send email to puppet-users@googlegroups.com.
To unsubscribe from this group, send email to
puppet-users+unsubscr...@googlegroups.com.
For more options, visit this group at
http://groups.google.com/group/puppet-users?hl=en.
