-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 >> Ok, some more data from git history: >> http://github.com/reductivelabs/facter/commit/33fb7709404e706801683e6c47ab7a0a5a1884b1 > >> It looks like "return an array" is new behavior for exec, and maybe it >> wasn't backported/tested for all of the old facts. Thoughts? > > Yeah - this is the issue. It's in HEAD so it's not committed to a > release - we can easily fix the facts or adjust or even revert the > commit.
Right, my fault. I thought that it would introduce a nice new behavior and didn't think of the old behavior, as well it looks like the old behavior wasn't tested enough. I would propose to just adjust that the exec still returns a string, as it have done before. >> In this case the best way to go is probably a "return type" parameter >> that defaults to strings, and things that want arrays can ask for >> them. > > Yeah - this is in line with where we're going with Facter anyway. Hmm, I'm not really a fan of such a return type thing. My proposal would be to have the old behavior (return a string) and then if somebody really rather likes an array in different places, they could write a wrapper method which would split the string for them. > I've re-opened http://projects.reductivelabs.com/issues/2766 with > your investigations. If we can agree on a solution, I'll write a patch. > Thanks for the hard yards poking around at it. yep, thanks! cheers pete -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iEYEARECAAYFAktHCG4ACgkQbwltcAfKi38ltQCePDX+3Rq1fzHZ8VK5WztgqlV9 ezoAn3yYQJshU74kIrGeh5d8A2oVcCHc =vdNF -----END PGP SIGNATURE-----
-- You received this message because you are subscribed to the Google Groups "Puppet Users" group. To post to this group, send email to puppet-us...@googlegroups.com. To unsubscribe from this group, send email to puppet-users+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/puppet-users?hl=en.
