Hi, I for one, thinks that the operatingsystemrelease fact should contain only the major number of the operating system, e.g. for Centos/Rehat 5.4 it should return just 5.
the reason behind it is that I rarely use the full release version as a variable, and if I do, I use the lsb facts. this change is very annoying, as it requires to change your manifest again (we had the same issue between facter 1.38 and 1.5.0). I ended up having my own fact which is just a wrapper for the operatingsystem relase, as it one point of time I might have multiple facter version running around.... Ohad On Wed, Oct 21, 2009 at 6:42 AM, Christopher <chris...@pricegrabber.com>wrote: > > Hello... > > I just started rolling out facter 1.5.7 (from 1.5.5) on our rhel 5.x > servers and ran into http://projects.reductivelabs.com/issues/2312 . In > a few of my fileserving classes I use the os release fact to determine > what file to serve. e.g. ntpd.conf.5 and ntpd.conf.3 for rhel5 and > rhel3 respectively. With the above bugfix my puppet clients now look > for ntpd.conf.5.4, which fails. I implemented a workaround, but wanted > a cleaner solution. What I came up with is below: > > > Facter.add("operatingsystemreleasemajor") do > confine :kernel => :FreeBSD > setcode do > Facter::operatingsystemrelease.gsub(/-\w+/,'') > end > end > > Facter.add("operatingsystemreleasemajor") do > confine :kernel => :Linux > setcode do > Facter::operatingsystemrelease.gsub(/\.\w+/,'') > end > end > > > which AFAICT, could just be appended to facter/operatingsystemrelease.rb > > What I get is: > > [chris...@rhel54 facterlib-test]$ facter | grep operatingsystem > operatingsystem => RedHat > operatingsystemrelease => 5.4 > > [chris...@rhel54 facterlib-test]$ export > FACTERLIB=/home/chrismcc/facterlib-test/ > > [chris...@rhel54 facterlib-test]$ facter | grep operatingsystem > operatingsystem => RedHat > operatingsystemrelease => 5.4 > operatingsystemreleasemajor => 5 > > and FreeBSD: > > [chris...@freebsd63 facterlib-test]$ facter | grep operatingsystem > operatingsystem => FreeBSD > operatingsystemrelease => 6.3-RELEASE-p13 > operatingsystemreleasemajor => 6.3 > > > I only have RHEL and FreeBSD to test on, but I do not think the code > will break on other OSs like debian/solaris/etc. > > > What are the chances of getting this into the next facter release, > assuming others think it useful? > > > > -- > Christopher McCrory > "The guy that keeps the servers running" > > chris...@pricegrabber.com > http://www.pricegrabber.com > > Let's face it, there's no Hollow Earth, no robots, and > no 'mute rays.' And even if there were, waxed paper is > no defense. I tried it. Only tinfoil works. > > > > > > --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Puppet Users" group. To post to this group, send email to puppet-users@googlegroups.com To unsubscribe from this group, send email to puppet-users+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/puppet-users?hl=en -~----------~----~----~----~------~----~------~--~---
