James Turnbull wrote: > Thanks for this - I rewrote the Rakefile tasks for the build and > suspected their might be teething problems.
:) Is the new Rakefile still the same as the patch you sent in http://groups.google.com/group/puppet-dev/msg/0d0bb27389321fa8 ? I applied that to test and noticed a few things that might be worth looking at closer. The require 'facter' will look for the system facter, which doesn't seem desirable. Adding: $: << File.expand_path('lib') (or whatever the proper ruby way of saying that is) seems like a Good Thing(TM) to me. (Trivial patch attached.) I also tripped over the ci_reporter requirement. Any chance that could be made to only be a requirement when the ci_spec task is requested? > The install.rb is an oversight that I'll fix. The documentation and > spec directories I deliberately excluded. The former because I > didn't think anyone still used it - happy to be corrected. The > latter because I didn't think the tests fitted into the release > tarball. Again - happy to be argued with/swayed on this. I don't have an informed opinion on either. I don't know if anyone would want to run the spec tests as part of their build process. We don't do that for the Fedora/EPEL packages at the moment, but it might be a nice thing to do someday. -- Todd OpenPGP -> KeyID: 0xBEAF0CE3 | URL: www.pobox.com/~tmz/pgp ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ A person who smiles in the face of adversity ... probably has a scapegoat.
From dc528275427cc193f61e4d7aa11ca769831aa4c4 Mon Sep 17 00:00:00 2001
From: Todd Zullinger <t...@pobox.com>
Date: Tue, 19 May 2009 23:14:37 -0400
Subject: [PATCH 1/2] Rakefile: Add lib to the search path
This ensures that facter is used from the current directory, rather than
another installed version on the system.
---
Rakefile | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/Rakefile b/Rakefile
index 58aab8b..0c3dffe 100644
--- a/Rakefile
+++ b/Rakefile
@@ -1,5 +1,7 @@
# Rakefile for facter
+# Add lib to the search path
+$: << File.expand_path('lib')
require 'facter'
require 'rake'
require 'rake/packagetask'
--
1.6.3.1
pgpcMS1kfm8Yf.pgp
Description: PGP signature
