On Thu, Mar 6, 2014 at 11:23 AM, Stefan Schulte <
[email protected]> wrote:

> Hi Erik,
>
> On 06.03.2014 09:28, Erik Dalén wrote:
> > Isn't this what was done in http://projects.puppetlabs.com/issues/3946 ?
> > So should be available in 3.4.0+
> >
> > Was discussed in this mail
> > thread: https://groups.google.com/forum/#!topic/puppet-dev/Iqs5jEGfu_0
>
> thanks for finding the ticket and pull request for me. I have looked
> into the implementation but if am not mistaken `post_resource_eval` will
> be called on every puppet run (after all resources are evaluated) no
> matter whether resources where out of sync or not.
>
> This is not quite what I want, because I only want to restart my
> application when one ore more resources have been changed.



I know I'm a little late to the party on this one, but the matter of naming
things has occurred to me.  Recently, I've run into a couple of use cases
where I could see the need for a callback that's executed after each
discrete resource is evaluated.  When I saw, post_resource_eval I thought
this might have been what I was thinking about anyway, but then I learned
(please correct me if I'm wrong) that post_resource_eval is actually a hook
into the point after all resources have been eveluated.

Would it make more sense to name what's currently implemented
post_catalog_eval in the event we do implement some hook for each discrete
resource?

If so, is it worth renaming it sooner rather than later?

-Jeff

-- 
You received this message because you are subscribed to the Google Groups 
"Puppet Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To view this discussion on the web visit 
https://groups.google.com/d/msgid/puppet-dev/CAOXx1vGmH1DVjM7EYtaLZ8gSRQRf8sO6M1UAQVq6Hyd0sR4%2Bnw%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.

Reply via email to