Jira (FACT-3109) Failed to get networking information: "\xE5" to UTF-8 in conversion from ASCII-8BIT to UTF-8 to UTF-16LE

Josh Cooper (Jira) Mon, 28 Mar 2022 13:25:05 -0700

Title: Message Title

Josh Cooper commented on

The error occurs when trying to read the "Friendly Name" for the interface. In Facter 3.x we used to do

net_interface.name = boost::nowide::narrow(pCurAddr->FriendlyName);

The boost libraries automatically convert the wide string friendly name to UTF-8 and most importantly they https://www.boost.org/doc/libs/develop/libs/nowide/doc/html/index.html

If there are non-UTF-8 characters in the passed string, the conversion will replace them by a replacement character (default: U+FFFD) similar to what the NT kernel does.

Since the "friendly name" is user editable, it's possible for the data to be incorrectly encoded (usually it's encoded based on the current code page instead of UTF-16LE). We should ensure we replace invalid chars when reading the friendly name.

1. Update facter's read_wide_string_without_length method to accept an optional argument to replace invalid chars. If set, call:

str.encode(Encoding::UTF_8, str.encoding, replace: invalid)

2. Update networking.rb to pass the optional argument

We already do something like this in puppet when reading garbage from the registry. See https://github.com/puppetlabs/puppet/blob/1b8c8a13b9e87ad12cf8452aade7c2ead0e34edc/lib/puppet/ffi/windows/api_types.rb#L53

Add Comment

This message was sent by Atlassian Jira

--
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.438363.1646388745000.1590.1648499100059%40Atlassian.JIRA.

Jira (FACT-3109) Failed to get networking information: "\xE5" to UTF-8 in conversion from ASCII-8BIT to UTF-8 to UTF-16LE

Reply via email to