Jira (PUP-10730) Old report processors don't work with the new puppetserver http client

Title: Message Title

Josh Cooper created an issue

Add the following report processor to lib/puppet/reports/legacy.rb, which is a simplified version of the http processor from puppet 5/6:

require 'puppet'

require 'puppet/network/http_pool'

require 'uri'

Puppet::Reports.register_report(:legacy) do

  def process

    url = "">URI.parse(Puppet[:reporturl])

    conn = Puppet::Network::HttpPool.http_instance(url.host, url.port, false)

    response = conn.post(url.path, self.to_yaml, { "Content-Type" => "application/x-yaml" })

    unless response.kind_of?(Net::HTTPSuccess)

      Puppet.err ("Unable to submit report to #{Puppet[:reporturl]} [#{response.code}] #{response.msg}")

end

end

end

Configure puppet.conf with:

[server]

reports = legacy

reporturl = http://localhost:8000/reports

Start a simple http server on port 8000, like python -m SimpleHTTPServer

Start puppetserver and run the agent, and the report processor will fail with:

020-10-28 11:26:04,868 ERROR [qtp470539277-446] [puppetserver] Puppet Report processor failed: undefined method `code' for nil:NilClass

/Users/josh/work/puppet/lib/puppet/reports/legacy.rb:35:in `process'

/Users/josh/work/puppet/lib/puppet/indirector/report/processor.rb:37:in `block in process'

/Users/josh/work/puppet/lib/puppet/indirector/report/processor.rb:54:in `block in processors'

org/jruby/RubyArray.java:1809:in `each'

/Users/josh/work/puppet/lib/puppet/indirector/report/processor.rb:51:in `processors'

/Users/josh/work/puppet/lib/puppet/indirector/report/processor.rb:30:in `process'

/Users/josh/work/puppet/lib/puppet/indirector/report/processor.rb:14:in `save'

This is because Puppet::HTTP::Response#nethttp returns nil

This message was sent by Atlassian Jira

--
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.376350.1603910048000.66499.1603910100131%40Atlassian.JIRA.

Reply via email to