Hello Roland,

On Fri, Jul 09, 2021 at 12:50:21PM +0200, Roland Hieber wrote:
> On Fri, Jul 09, 2021 at 08:59:08AM +0200, Alexander Dahl wrote:
> > Hello Roland,
> > 
> > On Fri, Jul 09, 2021 at 12:02:02AM +0200, Roland Hieber wrote:
> > > Signed-off-by: Roland Hieber <[email protected]>
> > 
> > I miss the reasoning for this change. What's the benefit?
> 
> Originally I tried to "fix" it because the nightly urlcheck run failed,
> but it turned out to be a temporary failure on the samba.org side.
> Nevertheless, HTTPS provides more security, 

Downloading some public source tarball without any credentials
necessary, I'm not convinced about the additional value.

> and the HTTP URL redirects
> to HTTPS anyway (same for the other patches in this series).

Well, I could accept that, saves at least a request.

A

> 
>  - Roland
> 
> > 
> > Greets
> > Alex
> > 
> > > ---
> > >  rules/ppp.make | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > 
> > > diff --git a/rules/ppp.make b/rules/ppp.make
> > > index 3c8a57fd9396..e39b87b45dd3 100644
> > > --- a/rules/ppp.make
> > > +++ b/rules/ppp.make
> > > @@ -20,7 +20,7 @@ PPP_VERSION     := 2.4.9
> > >  PPP_MD5          := c88153ae3d16ae114152cd3c15c7301d
> > >  PPP              := ppp-$(PPP_VERSION)
> > >  PPP_SUFFIX       := tar.gz
> > > -PPP_URL          := http://ftp.samba.org/pub/ppp/$(PPP).$(PPP_SUFFIX)
> > > +PPP_URL          := 
> > > https://www.samba.org/ftp/pub/ppp/$(PPP).$(PPP_SUFFIX)
> > >  PPP_SOURCE       := $(SRCDIR)/$(PPP).$(PPP_SUFFIX)
> > >  PPP_DIR          := $(BUILDDIR)/$(PPP)
> > >  PPP_LICENSE      := BSD AND GPL-2.0-only
> > > -- 
> > > 2.30.2
> 
> -- 
> Roland Hieber, Pengutronix e.K.          | [email protected]     |
> Steuerwalder Str. 21                     | https://www.pengutronix.de/ |
> 31137 Hildesheim, Germany                | Phone: +49-5121-206917-0    |
> Amtsgericht Hildesheim, HRA 2686         | Fax:   +49-5121-206917-5555 |
> 
> _______________________________________________
> ptxdist mailing list
> [email protected]
> To unsubscribe, send a mail with subject "unsubscribe" to 
> [email protected]

-- 
/"\ ASCII RIBBON | »With the first link, the chain is forged. The first
\ / CAMPAIGN     | speech censured, the first thought forbidden, the
 X  AGAINST      | first freedom denied, chains us all irrevocably.«
/ \ HTML MAIL    | (Jean-Luc Picard, quoting Judge Aaron Satie)

Attachment: signature.asc
Description: PGP signature

_______________________________________________
ptxdist mailing list
[email protected]
To unsubscribe, send a mail with subject "unsubscribe" to 
[email protected]

Reply via email to