On 1/6/20 12:24 PM, Michael Olbrich wrote: > On Wed, Dec 18, 2019 at 09:57:24AM +0100, Bastian Krause wrote: >> Hi Bruno, >> >> On 12/17/19 4:16 PM, Bruno Thomsen wrote: >>> Den fre. 29. nov. 2019 kl. 12.52 skrev Bastian Krause <[email protected]>: >>>> -TPM2_TOOLS_VERSION := 3.1.4 >>>> -TPM2_TOOLS_MD5 := 61b4a382d24c950148a3f5fe41ac2306 >>>> +TPM2_TOOLS_VERSION := 4.1 >>> >>> I just tested your version bump and found that our build still need >>> a minor change otherwise the prepare stage fails. >>> >>> $ ptxdist prepare tpm2-tools >>> >>> checking whether C compiler accepts -Wall... yes >>> checking whether C compiler accepts -Wextra... yes >>> checking whether C compiler accepts -Werror... yes >>> checking whether C compiler accepts -Wformat... yes >>> checking whether C compiler accepts -Wformat-security... yes >>> checking whether C compiler accepts -Wstack-protector... yes >>> checking whether C compiler accepts -fstack-protector-all... yes >>> checking whether C compiler accepts -Wstrict-overflow=5... yes >>> checking whether C compiler accepts -Wbool-compare... yes >>> checking whether C compiler accepts -O2... yes >>> checking whether to add -D_FORTIFY_SOURCE=2 to CPPFLAGS... yes >>> checking whether C compiler accepts -fPIC... yes >>> checking whether the linker accepts -shared... no >>> configure: error: Cannot enable -shared, consider configuring with >>> --disable-hardening >>> >>> >>> ptxdist platformconfig: >>> # >>> # hardening options >>> # >>> # PTXCONF_TARGET_HARDEN_STACK_NONE is not set >>> # PTXCONF_TARGET_HARDEN_STACK is not set >>> # PTXCONF_TARGET_HARDEN_STACK_STRONG is not set >>> PTXCONF_TARGET_HARDEN_STACK_ALL=y >>> PTXCONF_TARGET_HARDEN_STACKCLASH=y >>> PTXCONF_TARGET_HARDEN_FORTIFY=y >>> PTXCONF_TARGET_HARDEN_RELRO=y >>> PTXCONF_TARGET_HARDEN_BINDNOW=y >>> PTXCONF_TARGET_HARDEN_PIE=y >>> PTXCONF_TARGET_HARDEN_GLIBCXX_ASSERTIONS=y >>> >>> Disabling PIE does not change anything when using >>> arm-v7a-linux-gnueabihf-gcc. >>> >>>> # >>>> ---------------------------------------------------------------------------- >>>> # Prepare >>>> @@ -34,10 +34,12 @@ TPM2_TOOLS_LICENSE_FILES := >>>> file://LICENSE;md5=91b7c548d73ea16537799e8060cea819 >>>> TPM2_TOOLS_CONF_TOOL := autoconf >>>> TPM2_TOOLS_CONF_OPT := \ >>>> $(CROSS_AUTOCONF_USR) \ >>>> + --enable-debug=info \ >>>> --disable-code-coverage \ >>>> --disable-unit \ >>>> --enable-hardening \ >>>> - --without-gcov >>>> + --without-gcov \ >>>> + --without-bashcompdir >>> >>> TPM2_TOOLS_CFLAGS := \ >>> -fPIC >>> >>> >>> I don't know if this is the correct fix or something else is the root cause. >> >> Looks okay to me. Let's wait what Michael has to say about it. > > That makes sense to me. I think this should be handled correctly > internally, but I think for a lot if distributions that's already the > default in the toolchain, so it does not fail there.
Alright. Bruno, could you send this as a proper patch? Regards, Bastian -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ ptxdist mailing list [email protected]
