[
https://issues.apache.org/jira/browse/PROTON-964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14661903#comment-14661903
]
ASF GitHub Bot commented on PROTON-964:
---------------------------------------
Github user gemmellr commented on the pull request:
https://github.com/apache/qpid-proton/pull/48#issuecomment-128714379
Hi Bozo, sorry for the delay getting back to you, I was a bit
tunnel-visioned trying (and failing :/) to get 0.10 out the door this week.
I like the recent change giving the handler a method to handle events. I'm
not sure it really reduces (so much as perhaps moves) the casting much, but it
at least gives the Handler interface something to do other than onUnhandled and
also gives the Handler the decision over how to handle an Event rather than the
other way around, which seems nicer.
It would still be good for some other folks who actually wrote the
event/reactor stuff to take a look (like @rhs and @prestona, <poke>) but master
is open for 0.11 at this point....
> Proton-J extensible event types
> -------------------------------
>
> Key: PROTON-964
> URL: https://issues.apache.org/jira/browse/PROTON-964
> Project: Qpid Proton
> Issue Type: Improvement
> Components: proton-j
> Affects Versions: 0.10
> Reporter: Bozo Dragojevic
> Assignee: Bozo Dragojevic
> Fix For: 0.11
>
>
> Event.Type is an enum which makes it impossible to extend.
> Introduce a separate interface EventType and make Event.Type implement it.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
