[
https://issues.apache.org/jira/browse/PROTON-964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14653390#comment-14653390
]
ASF GitHub Bot commented on PROTON-964:
---------------------------------------
Github user gemmellr commented on a diff in the pull request:
https://github.com/apache/qpid-proton/pull/48#discussion_r36173420
--- Diff: proton-j/src/main/java/org/apache/qpid/proton/engine/Event.java
---
@@ -80,15 +83,46 @@
SELECTABLE_WRITABLE,
SELECTABLE_EXPIRED,
SELECTABLE_ERROR,
- SELECTABLE_FINAL
+ SELECTABLE_FINAL,
+
+ /**
+ * This value must never be used to generate an event, it's only
used as
+ * a guard when casting custom EventTypes to builtin {@link Type}
via
+ * {@link Event#getBuiltinType()}.
+ */
+ NOT_A_BUILTIN_TYPE;
--- End diff --
NOT_A_BUILTIN_TYPE similarly seems a bit off as a name. Perhaps following
in the theme of the work, something like EXTENDED, or following the earlier
suggestion, NON_CORE, etc?
Also, for the javadoc link, the Event#getBuiltinType() method doesnt exist.
> Proton-J extensible event types
> -------------------------------
>
> Key: PROTON-964
> URL: https://issues.apache.org/jira/browse/PROTON-964
> Project: Qpid Proton
> Issue Type: Improvement
> Components: proton-j
> Affects Versions: 0.10
> Reporter: Bozo Dragojevic
> Assignee: Bozo Dragojevic
> Fix For: 0.11
>
>
> Event.Type is an enum which makes it impossible to extend.
> Introduce a separate interface EventType and make Event.Type implement it.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
