On 04/21/2015 12:52 PM, Rafael Schloming wrote:
I'm seeing a couple of issues with the recently landed sasl changes. I'm
getting four test failures in the python tests (see details at the end).
I'm also seeing interop issues with the proton.js built prior to these
changes, and with these changes in place the javascript build seems to be
messed up (not finding new symbols).
Is anyone else seeing similar issues?
I can't even get as far as the tests. On a clean build
(cyrus-sasl-lib-2.1.23-31 installed) I get:
/home/gordon/projects/proton-git/proton-c/src/sasl/cyrus_sasl.c: In function
‘pn_sasl_free’:
/home/gordon/projects/proton-git/proton-c/src/sasl/cyrus_sasl.c:656:15: error:
implicit declaration of function ‘sasl_client_done’
[-Wimplicit-function-declaration]
/home/gordon/projects/proton-git/proton-c/src/sasl/cyrus_sasl.c:658:15: error:
implicit declaration of function ‘sasl_server_done’
[-Wimplicit-function-declaration]
make[2]: *** [proton-c/CMakeFiles/qpid-proton.dir/src/sasl/cyrus_sasl.c.o]
Error 1
If I set the SASL_IMPL in cmake to null (is that how you turn it off),
then I get:
CMakeFiles/qpid-proton.dir/src/dispatcher/dispatcher.c.o: In function
`pni_dispatch_action':
/home/gordon/projects/proton-git/proton-c/src/dispatcher/dispatcher.c:67:
undefined reference to `pn_do_response'
/home/gordon/projects/proton-git/proton-c/src/dispatcher/dispatcher.c:66:
undefined reference to `pn_do_challenge'
/home/gordon/projects/proton-git/proton-c/src/dispatcher/dispatcher.c:65:
undefined reference to `pn_do_init'
/home/gordon/projects/proton-git/proton-c/src/dispatcher/dispatcher.c:64:
undefined reference to `pn_do_mechanisms'
/home/gordon/projects/proton-git/proton-c/src/dispatcher/dispatcher.c:68:
undefined reference to `pn_do_outcome'
CMakeFiles/qpid-proton.dir/src/transport/transport.c.o: In function
`pn_io_layer_setup':
/home/gordon/projects/proton-git/proton-c/src/transport/transport.c:199:
undefined reference to `sasl_header_layer'
CMakeFiles/qpid-proton.dir/src/transport/transport.c.o: In function
`pn_transport_finalize':
/home/gordon/projects/proton-git/proton-c/src/transport/transport.c:574:
undefined reference to `pn_sasl_free'
CMakeFiles/qpid-proton.dir/src/transport/transport.c.o: In function
`pn_transport_bind':
/home/gordon/projects/proton-git/proton-c/src/transport/transport.c:623:
undefined reference to `pni_sasl_set_remote_hostname'
/home/gordon/projects/proton-git/proton-c/src/transport/transport.c:619:
undefined reference to `pn_sasl'
/home/gordon/projects/proton-git/proton-c/src/transport/transport.c:620:
undefined reference to `pni_sasl_set_user_password'
CMakeFiles/qpid-proton.dir/src/transport/transport.c.o: In function
`pn_io_layer_input_autodetect':
/home/gordon/projects/proton-git/proton-c/src/transport/transport.c:257:
undefined reference to `sasl_write_header_layer'
/home/gordon/projects/proton-git/proton-c/src/transport/transport.c:255:
undefined reference to `pn_sasl'
CMakeFiles/qpid-proton.dir/src/transport/transport.c.o: In function
`pn_transport_get_user':
/home/gordon/projects/proton-git/proton-c/src/transport/transport.c:520:
undefined reference to `pn_sasl_get_user'
collect2: error: ld returned 1 exit status
