[
https://issues.apache.org/jira/browse/PROTON-811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14297430#comment-14297430
]
Rafael H. Schloming commented on PROTON-811:
--------------------------------------------
Hi Adrian, thanks for the patch.
One comment on the approach... rather than directly exposing a call to write an
empty frame, it would be better to add a general purpose interface to the
transport for timer integration, e.g. have a Transport.deadline() or
Transport.timeout() that returns a time in the future that the transport needs
to be called, and then have a Transport.tick() or Transport.expired() that is
invoked at that point. This is because there are actually other timing related
things required by the spec, not just sending empty frames. Also it isn't
always necessary to send an empty frame if other activity has happened, so
providing a slightly more abstract interface and letting the Transport
implementation decide when it needs to do something and what exactly it needs
to do would be preferred.
> [PATCH] proton-j: no way to implement idle timeout of a connection
> ------------------------------------------------------------------
>
> Key: PROTON-811
> URL: https://issues.apache.org/jira/browse/PROTON-811
> Project: Qpid Proton
> Issue Type: Bug
> Components: proton-j
> Affects Versions: 0.8
> Reporter: Adrian Preston
> Attachments: 0001-idle_timeout.patch
>
>
> Proton-J does not provide access to idle timeout values and there appears to
> be no way to send a empty frame (as per section 2.4.5 of the AMQP 1.0
> standard)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
