I've seen a syntax error on src/google/protobuf/stubs/atomicops.h file.
The define GOOGLE_PROTOBUF_ATOMICOPS_ERROR has an error.
It's not possible to define "#error" inside a define.
It causes 'error: stray ‘#’ in program' compilation error.
The current code put *#error "..."* inside GOOGLE_PROTOBUF_ATOMICOPS_ERROR
and that is the error.
The cross compilation run once and put *#error "..."* in all
GOOGLE_PROTOBUF_ATOMICOPS_ERROR occurences along the code, but *#error
"..." *need to be cross compiled too, and it's done once.
In fact when 'error: stray ‘#’ in program' compilation error' occurs, it
should to generate a error message, but not this. It's an syntax error
inside this header file;
I proposed a fix in my Protobuf fork
(https://github.com/redivo/protobuf/commit/7ad8690c5d8a875881ba00c3551595a2676538ef).
I'd like to know how can I contribute sending my patch.
How can I request a code review or something else?
Thanks.
=)
--
You received this message because you are subscribed to the Google Groups
"Protocol Buffers" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/protobuf.
For more options, visit https://groups.google.com/d/optout.
