> Now - THAT's a Funny one - and one I can surely relate to around my > office - seeing so much BAD Coding here! Believe me you... > > -K-
Code review is a good thing... I am amazed at how many places just don't bother. I wrote a mickey mouse piece of software here and asked the b0ss to do a code review (mostly just to keep him in the loop) and he shrugged his shoulders and didn't seem to have any desire to do it... One time I was doing some technical work for a company as a consultant and after I passed the MCP exam, out of the blue they offered me a job to come on board as the "Code Guru"... They were thrilled with my prior work but still had me sit down for an oral test by the owner, lead programmer and a junior level programmer/support person. Hand me a hardcopy of PRODUCTION code, as I recall it was the VALID event for a textbox that user's entered passwords into. In 18 lines total, I found 5 errors... they all turned white as ghosts, the boss stood up and shook my hand and said "Welcome aboard", the lead programmer sat there stunned and the junior programmer ran off to change the code based on my recommendations... Lessons learned: a) code review is a good thing, and b) don't let junior level programmers write your security software... <g> Thanks, Matthew Jarvis || Business Systems Analyst IT Department McKenzie-Willamette Medical Center 1460 G Street, Springfield, OR 97477 || Ph: 541-744-6092 || Fax: 541-744-6145 -------------------------------------------------------------------------- Disclaimer: This electronic message may contain information that is Proprietary, Confidential, or legally privileged or protected. It is intended only for the use of the individual(s) and entity named in the message. If you are not an intended recipient of this message, please notify the sender immediately and delete the material from your computer. Do not deliver, distribute or copy this message and do not disclose its contents or take any action in reliance on the information it contains. _______________________________________________ Post Messages to: ProFox@leafe.com Subscription Maintenance: http://leafe.com/mailman/listinfo/profox OT-free version of this list: http://leafe.com/mailman/listinfo/profoxtech Searchable Archive: http://leafe.com/archives/search/profox This message: http://leafe.com/archives/byMID/profox/69f310c05dd83c48a84ba3769ce1ecf805ab6...@tntriexevs02.triadhospitals.net ** All postings, unless explicitly stated otherwise, are the opinions of the author, and do not constitute legal or medical advice. This statement is added to the messages for those lawyers who are too stupid to see the obvious.
