netudima commented on code in PR #4838:
URL: https://github.com/apache/cassandra/pull/4838#discussion_r3302618961
##########
src/java/org/apache/cassandra/utils/MerkleTree.java:
##########
@@ -1482,7 +1482,7 @@ static byte[] xor(byte[] left, byte[] right)
{
assert left.length == right.length;
- byte[] out = Arrays.copyOf(right, right.length);
+ byte[] out = new byte[right.length];
Review Comment:
good catch, it is strange that we have a copy here .. (taking in account the
lengths of the arrays are the same)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]