netudima commented on PR #4825: URL: https://github.com/apache/cassandra/pull/4825#issuecomment-4534173709
Hi, I am a bit confused the the description/intention of the patch: 1) sstableupgrade is suppose to be offline tool (means it should be executed when a Cassandra process is stopped), are we trying to change it as a part of this patch? 2) "Adding this flag to an offline tool introduced a known edge case" - it is unclear why the flag introduction changes anything in the context of the SSTable IDs: we just change the set of SSTables to convert but the overall mechanism is the same, so the id collision issue is not something new, introduced in this patch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
