Klose6 commented on code in PR #345:
URL: https://github.com/apache/cassandra-sidecar/pull/345#discussion_r3289653401
##########
server/src/main/java/org/apache/cassandra/sidecar/cdc/CdcPublisher.java:
##########
@@ -160,10 +160,25 @@ public void handle(Message<Object> event)
executorPools.executeBlocking(() -> {
restart();
return null;
- });
+ }).onFailure(t ->
handleAsyncFailure(ON_CDC_CONFIGURATION_CHANGED.address(), t));
}
}
+ /**
+ * Backstop for fire-and-forget {@code executeBlocking(...)} dispatches in
event-bus handlers.
+ * The handler methods ({@code restart}, {@code stop}) already catch and
record their own
+ * failures via {@code sidecarCdcStats}; this fires only when something
unexpected escapes
+ * (e.g. an {@link Error}, or a stats-counter increment that throws before
reaching the
+ * handler's own try/catch). Logging at ERROR + bumping
+ * {@link SidecarCdcStats#captureUnrecoverableCdcError(Throwable)} so the
issue is surfaced
+ * rather than silently dropped by the discarded {@code Future}.
+ */
Review Comment:
change it to simple words.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
