netudima commented on code in PR #4827:
URL: https://github.com/apache/cassandra/pull/4827#discussion_r3281457373
##########
.build/build-bench.xml:
##########
@@ -113,8 +117,8 @@
<!-- TODO
https://issues.apache.org/jira/browse/CASSANDRA-18873 -->
<!-- The classes listed below are broken, and so currently
ignored, see CASSANDRA-18873 -->
- <arg value="-e" if:blank="${benchmark.name}"/>
- <arg
value="AtomicBTreePartitionUpdateBench|BTreeSearchIteratorBench|BTreeTransformBench|BTreeUpdateBench|CompactionWideRowBench|FastThreadLocalBench|KeyLookupBench|(instance.*Bench)|LatencyTrackingBench|MessageOutBench|MutationBench|ReadWriteBench|SSTablePipeCursorBench|SSTableReadingCursorBench|SSTableReadingFileBench|SSTableReadingFileCursorBench|ZeroCopyStreamingBench"
if:blank="${benchmark.name}"/>
+ <arg value="-e"/>
Review Comment:
agreed with @michaelsembwever to use his version of splitting logic, so I
am removing this part of the patch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
