frankgh commented on code in PR #4820:
URL: https://github.com/apache/cassandra/pull/4820#discussion_r3262488449
##########
src/java/org/apache/cassandra/io/sstable/format/bti/BtiTableWriter.java:
##########
@@ -330,13 +330,16 @@ protected SequentialWriter openDataWriter()
{
checkState(!dataWriterOpened, "Data writer has been already
opened.");
- return DataComponent.buildWriter(descriptor,
- getTableMetadataRef().getLocal(),
- getIOOptions().writerOptions,
- getMetadataCollector(),
-
ensuringInBuildInternalContext(operationType),
- getIOOptions().flushCompression,
-
getCompressionDictionaryManager());
+ SequentialWriter sequentialWriter =
DataComponent.buildWriter(descriptor,
+
getTableMetadataRef().getLocal(),
+
getIOOptions().writerOptions,
+
getMetadataCollector(),
+
ensuringInBuildInternalContext(operationType),
+
getIOOptions().flushCompression,
+
getCompressionDictionaryManager());
+ dataWriterOpened = true;
Review Comment:
this is missing setting `dataWriterOpened`. This doesn't seem to have any
functional issues at the moment, but adding the fix for completeness
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
