pauloricardomg commented on code in PR #351: URL: https://github.com/apache/cassandra-sidecar/pull/351#discussion_r3262239400
########## server/src/main/java/org/apache/cassandra/sidecar/configmanagement/ConfigurationProvider.java: ########## @@ -0,0 +1,66 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.cassandra.sidecar.configmanagement; + +import org.apache.cassandra.sidecar.cluster.instance.InstanceMetadata; +import org.jetbrains.annotations.NotNull; +import org.jetbrains.annotations.Nullable; + +/** + * Provides storage and retrieval of configuration overlays for Cassandra instances. + * + * <p>The provider is a pluggable abstraction that decouples configuration storage from the + * Configuration Manager. Implementations may persist overlays locally (files), remotely + * (etcd, Consul, HTTP APIs), or in-memory (for testing). + * + * <p>The provider stores version-agnostic overlays and does not perform version-specific + * validation or merge logic. Validation against a version-aware schema and computing updated + * overlays (via {@link CassandraConfigurationOverlay#updated}) are the responsibility of the + * Configuration Manager. + */ +public interface ConfigurationProvider +{ + /** + * Retrieve the configuration overlay for the given Cassandra instance. + * + * @param instance the Cassandra instance metadata + * @return the configuration overlay snapshot, or {@code null} if no overlay exists for the instance + */ + @Nullable + ConfigurationOverlaySnapshot getConfiguration(InstanceMetadata instance); Review Comment: good call, updated on f651dd81 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
