bschoening commented on code in PR #4813:
URL: https://github.com/apache/cassandra/pull/4813#discussion_r3260623479
##########
pylib/cqlshlib/copyutil.py:
##########
@@ -1752,6 +1752,7 @@ def format_value(self, val, cqltype):
formatted = formatter(val, cqltype=cqltype,
encoding=self.encoding, colormap=NO_COLOR_MAP,
date_time_format=self.date_time_format,
float_precision=cqltype.precision,
nullval=self.nullval, quote=False,
+ escape_backslash=False,
Review Comment:
Consider an alternative approach where formatted_value() bypasses display
formatting for text.
##########
pylib/cqlshlib/copyutil.py:
##########
@@ -1752,6 +1752,7 @@ def format_value(self, val, cqltype):
formatted = formatter(val, cqltype=cqltype,
encoding=self.encoding, colormap=NO_COLOR_MAP,
date_time_format=self.date_time_format,
float_precision=cqltype.precision,
nullval=self.nullval, quote=False,
+ escape_backslash=False,
decimal_sep=self.decimal_sep,
thousands_sep=self.thousands_sep,
boolean_styles=self.boolean_styles)
return formatted
Review Comment:
Please add unit tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
