raj14243 commented on code in PR #1941:
URL:
https://github.com/apache/cassandra-gocql-driver/pull/1941#discussion_r3251530097
##########
query_executor.go:
##########
@@ -383,17 +383,19 @@ func (q *internalQuery) attempt(keyspace string, end,
start time.Time, iter *Ite
if q.qryOpts.observer != nil {
metricsForHost := q.hostMetricsManager.attempt(latency, host)
q.qryOpts.observer.ObserveQuery(q.qryOpts.context,
ObservedQuery{
- Keyspace: keyspace,
- Statement: q.qryOpts.stmt,
- Values: q.qryOpts.values,
- Start: start,
- End: end,
- Rows: iter.numRows,
- Host: host,
- Metrics: metricsForHost,
- Err: iter.err,
- Attempt: attempt,
- Query: q.originalQuery,
+ Keyspace: keyspace,
+ Statement: q.qryOpts.stmt,
+ StatementKeyspace: q.routingInfo.getKeyspace(),
Review Comment:
I will check the `internalQuery.Keyspace()` I agree with @joao-r-reis on not
having CQL parsing. I started this PR as we were internally parsing statement
to extract keyspace and wanted to avoid that :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
