andresbeckruiz commented on PR #4746: URL: https://github.com/apache/cassandra/pull/4746#issuecomment-4462961321
Discussed with @belliottsmith offline- adding a check for `array[MAX_KEYS] == null` in the `clearBranchBuffer` method ensures that we only skip clearing a buffer if all keys and children have been cleared from the buffer. I've added back the `clearBranchBuffer` and `clearLeafBuffer` optimizations, used them to also clear `savedBuffer`, and also removed `AbstractUpdater` since it no longer contains any logic-- everything is consolidated in the `AbstractFastBuilder`. All `BTree` unit tests pass locally, as well as the JvmD test added in this patch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
