netudima commented on code in PR #4789:
URL: https://github.com/apache/cassandra/pull/4789#discussion_r3237167612
##########
src/java/org/apache/cassandra/db/ReadResponse.java:
##########
@@ -288,8 +325,8 @@ static abstract class DataResponse extends ReadResponse
// TODO: can the digest be calculated over the raw bytes now?
// The response, serialized in the current messaging version
private final ByteBuffer data;
- private final ByteBuffer repairedDataDigest;
- private final boolean isRepairedDigestConclusive;
+ protected ByteBuffer repairedDataDigest;
+ protected boolean isRepairedDigestConclusive;
Review Comment:
thanks, good idea, I was too focused on trying to keep the logic in a
constructor and missed an option with a factory method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
