frankgh commented on code in PR #327:
URL: https://github.com/apache/cassandra-sidecar/pull/327#discussion_r3211154318
##########
server/src/main/java/org/apache/cassandra/sidecar/cluster/CassandraAdapterDelegate.java:
##########
@@ -520,6 +521,25 @@ public boolean isJmxUp()
return nodeSettingsFromJmx != null;
}
+ /**
+ * @return the Cassandra host UUID fetched via JMX
+ * @throws CassandraUnavailableException when JMX is not available
+ */
+ @NotNull
+ public UUID hostId() throws CassandraUnavailableException
Review Comment:
I think this belongs in the NodeSettings class instead, I think we should
add it there instead
##########
client-common/src/main/java/org/apache/cassandra/sidecar/common/response/OperationalJobResponse.java:
##########
@@ -37,17 +38,35 @@ public class OperationalJobResponse
private final OperationalJobStatus status;
private final String operation;
private final String reason;
+ private final String startTime;
Review Comment:
any reason why we use string for startTime and lastUpdate instead of a time
data structure?
##########
server/src/main/java/org/apache/cassandra/sidecar/handlers/ListOperationalJobsHandler.java:
##########
@@ -72,7 +70,11 @@ protected void handleInternal(RoutingContext context,
HttpServerRequest httpRequ
ListOperationalJobsResponse listResponse = new
ListOperationalJobsResponse();
jobManager.allInflightJobs()
.stream()
- .map(job -> new OperationalJobResponse(job.jobId(), RUNNING,
job.name(), null))
+ .map(job -> new OperationalJobResponse(job.jobId(),
job.status(), job.name(), null,
Review Comment:
maybe introduce a builder for this constructor?
##########
CHANGES.txt:
##########
@@ -4,6 +4,7 @@
0.3.0
-----
+ * Update OperationalJob class to support cluster-wide operations
(CASSSIDECAR-376)
Review Comment:
we should move this under 0.4.0 instead
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
