netudima commented on code in PR #4745:
URL: https://github.com/apache/cassandra/pull/4745#discussion_r3141808716


##########
src/java/org/apache/cassandra/config/DataStorageSpec.java:
##########
@@ -412,6 +413,7 @@ public final static class IntMebibytesBound extends 
DataStorageSpec
         public IntMebibytesBound(String value)
         {
             super(value, MEBIBYTES, Integer.MAX_VALUE);
+            bytes = Ints.saturatedCast(unit().toBytes(quantity()));

Review Comment:
   yes, it makes sense, while I've seen this issue only in the described use 
case, it may impact other scenarios I've not checked yet too, so I will apply 
it for other implementations



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to