dcapwell commented on code in PR #4684:
URL: https://github.com/apache/cassandra/pull/4684#discussion_r3140580867
##########
src/java/org/apache/cassandra/service/consensus/migration/ConsensusMigrationMutationHelper.java:
##########
@@ -204,6 +204,29 @@ public static <T extends IMutation> void
splitMutationsIntoAccordAndNormal(Clust
}
}
+ public static <T extends IMutation> boolean
isSingleTokenStatementSpanningAccordAndNonAccordTables(ClusterMetadata cm, T
mutation)
+ {
+ if (mutation.potentialTxnConflicts().allowed ||
mutation.getTableIds().size() == 1)
+ return false;
+
+ Token token = mutation.key().getToken();
+
+ boolean containsAccordMutation = false;
+ boolean containsNormalMutation = false;
+
+ for (TableId tableId : mutation.getTableIds())
+ {
+ boolean test = tokenShouldBeWrittenThroughAccord(cm, tableId,
token, TransactionalMode::nonSerialWritesThroughAccord,
TransactionalMigrationFromMode::nonSerialWritesThroughAccord);
+ containsAccordMutation = containsAccordMutation || test;
+ containsNormalMutation = containsNormalMutation || !test;
Review Comment:
```suggestion
containsNormalMutation != !test;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
