jyothsnakonisa commented on code in PR #333:
URL: https://github.com/apache/cassandra-sidecar/pull/333#discussion_r3120482765
##########
client-common/src/main/java/org/apache/cassandra/sidecar/common/data/SSTableImportOptions.java:
##########
@@ -18,21 +18,28 @@
package org.apache.cassandra.sidecar.common.data;
-import java.util.HashMap;
+import java.util.LinkedHashMap;
/**
* Options for Cassandra import nodetool command. It is like properties.
* Supports Json serialization and deserialization.
+ * <p>
+ * This class is used exclusively in the S3 restore job path ({@code
CreateRestoreJobRequestPayload}).
*/
-public class SSTableImportOptions extends HashMap<String, String>
+public class SSTableImportOptions extends LinkedHashMap<String, String>
Review Comment:
Is there a reason why this had to be changed to LinkedHashMap?
##########
adapters/adapters-cassandra50/src/main/java/org/apache/cassandra/sidecar/adapters/cassandra50/Cassandra50TableOperations.java:
##########
@@ -0,0 +1,71 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.cassandra.sidecar.adapters.cassandra50;
+
+import java.util.Collections;
+import java.util.List;
+
+import org.apache.cassandra.sidecar.adapters.base.CassandraTableOperations;
+import org.apache.cassandra.sidecar.common.server.JmxClient;
+import org.jetbrains.annotations.NotNull;
+
+/**
+ * A {@link CassandraTableOperations} extension for Cassandra 5.0 that
supports SAI index validation
+ * parameters when importing SSTables.
+ */
+public class Cassandra50TableOperations extends CassandraTableOperations
+{
+ private final JmxClient jmxClient;
+
+ public Cassandra50TableOperations(JmxClient jmxClient)
+ {
+ super(jmxClient);
+ this.jmxClient = jmxClient;
Review Comment:
Instead of having separate jmxclient field in this class, can u make the
base class's field protected and use it here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
