smiklosovic commented on code in PR #4762: URL: https://github.com/apache/cassandra/pull/4762#discussion_r3119308669
########## conf/cassandra_latest.yaml: ########## @@ -2503,25 +2503,25 @@ default_secondary_index_enabled: true # It is possible to implement custom startup checks by implementing StatupCheck interface # and placing JAR on a classpath, using SPI mechanism. # -#startup_checks: -# Verifies correct ownership of attached locations on disk at startup. See CASSANDRA-16879 for more details. -# check_filesystem_ownership: -# enabled: false -# ownership_token: "sometoken" # (overriden by "CassandraOwnershipToken" system property) -# ownership_filename: ".cassandra_fs_ownership" # (overriden by "cassandra.fs_ownership_filename") +startup_checks: # Enable this property to fail startup if the node is down for longer than max(gc_grace_seconds, minimum_threshold), # to potentially prevent data resurrection on tables with deletes. # By default, this will run against all keyspaces and tables except the # ones specified on excluded_keyspaces and excluded_tables. -# check_data_resurrection: -# enabled: false + check_data_resurrection: + enabled: true # # Minimum grace period for the check, defaults to 0. Useful when gc_grace_seconds is very # # small (e.g. 0) to avoid blocking startup immediately. -# minimum_threshold: 3h + minimum_threshold: 3h Review Comment: @skoppu22 this is cassandra_latest.yaml, not cassandra.yaml. If somebody upgrades they will upgrade to cassandra.yaml where it is turned off. We do not have any real guarantees in cassandra_latest.yaml. It is suitable just for having latest stuff and "recommended settings" which can people start to use for their new clusters or for the evaluation of this tech as such, but we never established that a user can upgrade from one cassandra_latest.yaml to the other and expect it all to _just work_. You get these guarantees in cassandra.yaml instead. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
