joao-r-reis commented on code in PR #1942:
URL:
https://github.com/apache/cassandra-gocql-driver/pull/1942#discussion_r3102560681
##########
session.go:
##########
@@ -149,6 +149,15 @@ func NewSession(cfg ClusterConfig) (*Session, error) {
return nil, fmt.Errorf("the default SerialConsistency level is
not allowed to be anything else but SERIAL or LOCAL_SERIAL. Recived value: %v",
cfg.SerialConsistency)
}
+ logger := cfg.newLogger()
Review Comment:
> Us switching to just fixing the bug and having this in notes is just OK
imho.
I think the issue is that switching to the correct behavior might lead to
user apps breaking because their data is already written as empty instead of
NULL on their databases so after the user upgrades and starts writing the new
data as NULL then they will end up in a situation where the old data is not
NULL and the new data is NULL but in reality both data values were encoded from
the same input.
I do find it odd that we've not seen this bug reported before or maybe it
was and I didn't see it (I haven't been involved with the project for that
long). Maybe it's because what ultimately matters is that the data that comes
back from a read is the same as the data that was written even if the
underlying value in the database is not the correct one...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
