smiklosovic commented on code in PR #1942:
URL:
https://github.com/apache/cassandra-gocql-driver/pull/1942#discussion_r3095533378
##########
session.go:
##########
@@ -149,6 +149,15 @@ func NewSession(cfg ClusterConfig) (*Session, error) {
return nil, fmt.Errorf("the default SerialConsistency level is
not allowed to be anything else but SERIAL or LOCAL_SERIAL. Recived value: %v",
cfg.SerialConsistency)
}
+ logger := cfg.newLogger()
Review Comment:
@jameshartig I would not warn anybody at all but that is just my
preference, not going to "die on this hill". If they were affected, then they
would have to be in a situation when they are 1) aware of this bug 2) their
"nullity check" on UDT means that they are iterating over all fields in UDT and
check if it is null themselves. I do not think there is anybody out there who
is doing this. We would be having this bug reported already. Us switching to
just fixing the bug and having this in notes is just OK imho.
_encode nil maps as NULL values in Cassandra._ - this IS the correct
behavior.
But take this as just a feedback from somebody external, I do not know what
you guys really prefer. Ultimately up to you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
