netudima commented on code in PR #4539:
URL: https://github.com/apache/cassandra/pull/4539#discussion_r3085295544


##########
src/java/org/apache/cassandra/config/CassandraRelevantProperties.java:
##########
@@ -519,7 +519,7 @@ public enum CassandraRelevantProperties
      */
     SEED_COUNT_WARN_THRESHOLD("cassandra.seed_count_warn_threshold"),
     
SERIALIZATION_EMPTY_TYPE_NONEMPTY_BEHAVIOR("cassandra.serialization.emptytype.nonempty_behavior"),
-    SET_SEP_THREAD_NAME("cassandra.set_sep_thread_name", "true"),
+    SET_SEP_THREAD_NAME("cassandra.set_sep_thread_name", "false"),

Review Comment:
   originally I thought that it would be easy to do, but then I have realised 
that there is no suitable existing JMX bean for it and I'll have to introduce a 
new one, so it becomes more expensive (add bean, publication for it, 
unregistering, API to retrieve the value), so this is why actually the change 
is still non-merged :-).
   If we do not have a real case I would suggest to keep the current change 
simple, with ability to change the parameter via restart, and add the runtime 
change feature later in case of a real demand.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to