smiklosovic commented on code in PR #4699: URL: https://github.com/apache/cassandra/pull/4699#discussion_r3069362521
########## conf/cassandra.yaml: ########## @@ -2682,6 +2682,20 @@ max_security_label_length: 48 # compressed by dictionary compressor and training_min_frequency is set to 0m (the default when unset). #unset_training_min_frequency_enabled: true +# Minimum client driver versions. Connections from drivers whose version is below +# the configured minimum will be warned or rejected. Connections that do not report +# a driver name or version are considered valid. The map key is the driver name Review Comment: I am just thinking where this is going to be actually exercised? It is not like you are running drivers without any driver id every other day that this would be so common it would need to have a lot of attention. For 99.9% of cases your connections will always have identifiers in some fashion. At least everything under Apache Cassandra umbrella should have (not sure what the situation is with c++ or nodejs drivers etc but they should have the very same concept of driver ids). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
