tolbertam commented on code in PR #4699: URL: https://github.com/apache/cassandra/pull/4699#discussion_r3068427566
########## conf/cassandra.yaml: ########## @@ -2682,6 +2682,20 @@ max_security_label_length: 48 # compressed by dictionary compressor and training_min_frequency is set to 0m (the default when unset). #unset_training_min_frequency_enabled: true +# Minimum client driver versions. Connections from drivers whose version is below +# the configured minimum will be warned or rejected. Connections that do not report +# a driver name or version are considered valid. The map key is the driver name +# as reported in the native protocol STARTUP message. The value is the minimum +# version string. +#minimum_client_driver_versions_warned: +# DataStax Java Driver: "4.0.0" Review Comment: It is surprising to me that one can use spaces in YAML keys, interesting! Part of me wants to advocate for some kind of convention, e.g. lower case everything and separate spaces by `_`, but then that may create some ambiguity. Overall, I think this approach will work fine. We probably would not want to accept spaces in yaml keys in the regular config, but since these properties are driven by values that come from elsewhere (the drivers themselves), this seems fine. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
