frankgh commented on code in PR #4722:
URL: https://github.com/apache/cassandra/pull/4722#discussion_r3066780651


##########
src/java/org/apache/cassandra/db/rows/DeserializationHelper.java:
##########
@@ -148,4 +152,19 @@ public <V> V maybeClearCounterValue(V value, 
ValueAccessor<V> accessor)
                ? CounterContext.instance().clearAllLocal(value, accessor)
                : value;
     }
+
+    /**
+     * @param source the original source of {@link DataInput}
+     * @param limit  the limit number of bytes to read
+     * @return a reusable {@link TrackedDataInputPlus} scoped to this 
partition's deserialization lifetime.
+     * The instance is lazily created on first use and reused for every row in 
the partition.
+     */
+    public TrackedDataInputPlus trackedDataInputPlus(DataInput source, long 
limit)

Review Comment:
   just realized that there are no unit tests for this class. Let me see where 
we can add some tests for this.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to