abenn135 opened a new pull request, #1943: URL: https://github.com/apache/cassandra-gocql-driver/pull/1943
This supersedes https://github.com/apache/cassandra-gocql-driver/pull/1820 rebasing on top of, and taking into account, changes in v2. Notably, this removes the ability to mutate the Statement in the Interceptor -- it is now embedded in the `internalRequest`, making it inaccessible to a public API without invasive refactoring. Additionally, I modified `queryMetrics` in a few ways: * Made it threadsafe, so that latency and attempt count are updated under lock, preventing a potential race when reading latency * Separated out "attempts started" from "attempts completed". Speculative execution means that several attempts could happen concurrently, and this guarantees that (a) each attempt/interception gets its own attempt count, and (b) the retry policy respects attempts started, to prevent over-retry when earlier retries haven't completed yet. Fixes #1786. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
