sarankk commented on code in PR #334:
URL: https://github.com/apache/cassandra-sidecar/pull/334#discussion_r3059977924


##########
.circleci/config.yml:
##########
@@ -119,16 +119,16 @@ jobs:
     docker:
       - image: cimg/openjdk:11.0
     environment:
-      INTEGRATION_MAX_PARALLEL_FORKS: 3
-      INTEGRATION_MAX_HEAP_SIZE: "2500M"
+      INTEGRATION_MAX_PARALLEL_FORKS: 2
+      INTEGRATION_MAX_HEAP_SIZE: "2000M"
     resource_class: large
     steps:
       - install_common
       - checkout
       - attach_workspace:
           at: dtest-jars
       - run: ./scripts/install-shaded-dtest-jar-local.sh
-      - run: ./gradlew --no-daemon -PdtestVersion=4.0.16 
-Dcassandra.sidecar.versions_to_test="4.0" checkstyleIntegrationTest 
integrationTestLightWeight --stacktrace
+      - run: ./gradlew --no-daemon --max-workers=2 -PdtestVersion=4.0.16 
-Dcassandra.sidecar.versions_to_test="4.0" checkstyleIntegrationTest 
integrationTestLightWeight --stacktrace

Review Comment:
   Thanks @skoppu22 for the fix, could you also add a comment, why this setting 
is important, will be good for referring back.



##########
.circleci/config.yml:
##########
@@ -119,16 +119,16 @@ jobs:
     docker:
       - image: cimg/openjdk:11.0
     environment:
-      INTEGRATION_MAX_PARALLEL_FORKS: 3
-      INTEGRATION_MAX_HEAP_SIZE: "2500M"
+      INTEGRATION_MAX_PARALLEL_FORKS: 2
+      INTEGRATION_MAX_HEAP_SIZE: "2000M"

Review Comment:
   Nice, setting `INTEGRATION_MAX_PARALLEL_FORKS: 2` makes sense since we are 
setting `--max-workers=2` 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to