smiklosovic commented on code in PR #330: URL: https://github.com/apache/cassandra-sidecar/pull/330#discussion_r3053349360
########## docker/cdc-demo/scripts/start.sh: ########## @@ -0,0 +1,83 @@ +#!/usr/bin/env bash +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# +# Builds the sidecar image and starts the CDC demo stack. +# +# Usage (from anywhere in the repo): +# ./scripts/start.sh # build + start, keep existing data volumes +# ./scripts/start.sh --clean # build + start, wipe all data +set -euo pipefail + +# ANSI color codes Review Comment: What am I supposed to do when it is all started and I want to just stop it. Doing docker-compose down on my own? "stop.sh" is more intuitive. "stopping" should also ideally remove the containers, I would like to not see see Exited containers in "docker ps" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
