alanwang67 commented on code in PR #4692:
URL: https://github.com/apache/cassandra/pull/4692#discussion_r3054141727
##########
src/java/org/apache/cassandra/db/compaction/CompactionManager.java:
##########
@@ -612,7 +619,12 @@ public Object call() throws Exception
FBUtilities.waitOnFutures(futures);
assert compacting.originals().isEmpty();
logger.info("Finished {} for {}.{} successfully",
operationType, keyspace, table);
- return AllSSTableOpStatus.SUCCESSFUL;
+
+ // Some SSTables were not fully cleaned up because Accord is
still using those ranges
Review Comment:
I see, though we can only have an incomplete operation with cleanup, but let
me fix the comment to be more general. Do we want to extend this to the other
operations as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
