netudima commented on code in PR #4702:
URL: https://github.com/apache/cassandra/pull/4702#discussion_r3036763354
##########
test/unit/org/apache/cassandra/db/compaction/CompactionsCQLTest.java:
##########
@@ -903,9 +907,36 @@ public void testNoDiskspace() throws Throwable
{
CompactionManager.instance.active.finishCompaction(holder);
}
+
+ // Should be able to run when the sstables in question are 90% of the
total available space
+ holder = holder(OperationType.COMPACTION, 0.9);
+ CompactionManager.instance.active.beginCompaction(holder);
+ try
+ {
+ getCurrentColumnFamilyStore().forceMajorCompaction();
+ }
+ finally
+ {
+ CompactionManager.instance.active.finishCompaction(holder);
+ }
+ }
+
+ private static final class OnDiskLengthOverrideSSTableReader extends
ForwardingSSTableReader
Review Comment:
just wondering what is the purpose of the Reader substitution?.. (if in any
way we use a custom Holder to return getCompactionInfo)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
