aweisberg commented on code in PR #4696:
URL: https://github.com/apache/cassandra/pull/4696#discussion_r3029944662
##########
test/distributed/org/apache/cassandra/distributed/test/sai/PartialUpdateHandlingTest.java:
##########
@@ -236,7 +236,11 @@ public void writeRepairedRows()
CLUSTER.coordinator(1).execute(insert.toString(),
ConsistencyLevel.ALL);
}
- CLUSTER.get(1).nodetoolResult("repair",
specification.keyspaceName()).asserts().success();
+ // Background reconciliation doesn't exist/work so incremental
repair just hangs waiting for reconciliation that never occurs
+ if (specification.replicationType.isTracked())
+ CLUSTER.get(1).nodetoolResult("repair", "-full",
specification.keyspaceName()).asserts().success();
Review Comment:
Ah right now I remember. So the test inserts data using `executeInternal`
which gives the mutation and id and applys it locally correclty, but because
it's only applied locally it never propagates because there is no background
reconciliation.
Mutations applied via execute/StorageProxy are given to ActiveLogReconciler
which is basically in-memory hinted handoff for mutation tracking.
So this is working as intended for now in that we need to use full repair
here instead of IR since IR can't complete until background reconciliation is
done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
