maedhroz commented on code in PR #4696:
URL: https://github.com/apache/cassandra/pull/4696#discussion_r3029128326
##########
src/java/org/apache/cassandra/db/AbstractMutationVerbHandler.java:
##########
@@ -202,6 +202,13 @@ else if
(message.epoch().isBefore(metadata.schema.lastModified()))
*/
protected ClusterMetadata checkReplicationMigration(ClusterMetadata
metadata, Message<T> message, InetAddressAndPort respondTo)
{
+ // Read repair mutations always bypass mutation tracking and use the
untracked
+ // write path, so skip the replication migration routing check. The
isReadRepair
+ // flag on the mutation hasn't been set yet at this point — it's set
later in
+ // applyMutation() — so we check the handler type instead.
+ if (this instanceof ReadRepairVerbHandler)
+ return metadata;
Review Comment:
nit: I guess the other option would be something like a
`handlesReadRepair()` method that only `ReadRepairVerbHandler` overrides, but
it's literally called `ReadRepairVerbHandler`, and we probably won't have
something else handle RR mutations.
In any case, I'm remembering blocking RR is going to be reworked for
migration anyway, so ignore me :D
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
