Copilot commented on code in PR #1284:
URL:
https://github.com/apache/cassandra-python-driver/pull/1284#discussion_r3025858522
##########
docs/upgrading.rst:
##########
@@ -4,9 +4,51 @@ Upgrading
.. toctree::
:maxdepth: 1
+Upgrading to 3.30.0
+-------------------
+Version 3.30.0 of the Python driver is the first release since the driver's
donation
+to the Apache Software Foundation (ASF).
+
+Supported Python Versions
+^^^^^^^^^^^^^^^^^^^^^^^^^
+An individual version of the Python driver aims to officially support all
Python runtimes
+that are not end-of-life (EOL) at the time of that versions release. For
3.30.0 this policy
+entails support for Python 3.10 through Python 3.14. The driver will likely
continue to work
+reasonably well on older Python runtimes but only these versions are
officially supported.
+
+Conversion to pyproject.toml
+^^^^^^^^^^^^^^^^^^^^^^^^^^^^
+With this release we are moving away from the install and configuration
process based on
+setup.py and towards the use of pyproject.toml. As a result of this change
(and in keeping
+with the uses of pyproject.toml) configuration of a driver build is now
declarative. All
+build options should be specified in pyproject.toml and overrides via
command-line flags or
+environment varaibles are no longer supported. Please consult
+`CASSPYTHON-7 <https://issues.apache.org/jira/browse/CASSPYTHON-7>`_ for
additional details.
+
+Event Loop Deprecation
+^^^^^^^^^^^^^^^^^^^^^^
+With this release the eventlet, gevent and Twisted event loops are considered
deprecated. Use
+of these event loops in this version will generate a warning to this effect.
We are planning on
+removing these event loops in their entirety in the next minor release.
Please consult
+`CASSPYTHON-12 <https://issues.apache.org/jira/browse/CASSPYTHON-12>`_ for
additional details.
+
+Removal of Win32 Wheels
+^^^^^^^^^^^^^^^^^^^^^^^
+As of this release we will no longer be offering wheels for Win32 platforms.
Wheels for other
+Windows platforms will continue to be deployed to PyPi. Please consult
Review Comment:
Spelling/branding: PyPI is typically capitalized "PyPI" (not "PyPi").
```suggestion
Windows platforms will continue to be deployed to PyPI. Please consult
```
##########
docs/upgrading.rst:
##########
@@ -4,9 +4,51 @@ Upgrading
.. toctree::
:maxdepth: 1
+Upgrading to 3.30.0
+-------------------
+Version 3.30.0 of the Python driver is the first release since the driver's
donation
+to the Apache Software Foundation (ASF).
+
+Supported Python Versions
+^^^^^^^^^^^^^^^^^^^^^^^^^
+An individual version of the Python driver aims to officially support all
Python runtimes
+that are not end-of-life (EOL) at the time of that versions release. For
3.30.0 this policy
Review Comment:
Typo/grammar: "that versions release" is missing the possessive apostrophe;
it should be "that version's release".
```suggestion
that are not end-of-life (EOL) at the time of that version's release. For
3.30.0 this policy
```
##########
docs/upgrading.rst:
##########
@@ -4,9 +4,51 @@ Upgrading
.. toctree::
:maxdepth: 1
+Upgrading to 3.30.0
+-------------------
+Version 3.30.0 of the Python driver is the first release since the driver's
donation
+to the Apache Software Foundation (ASF).
+
+Supported Python Versions
+^^^^^^^^^^^^^^^^^^^^^^^^^
+An individual version of the Python driver aims to officially support all
Python runtimes
+that are not end-of-life (EOL) at the time of that versions release. For
3.30.0 this policy
+entails support for Python 3.10 through Python 3.14. The driver will likely
continue to work
+reasonably well on older Python runtimes but only these versions are
officially supported.
+
+Conversion to pyproject.toml
+^^^^^^^^^^^^^^^^^^^^^^^^^^^^
+With this release we are moving away from the install and configuration
process based on
+setup.py and towards the use of pyproject.toml. As a result of this change
(and in keeping
+with the uses of pyproject.toml) configuration of a driver build is now
declarative. All
Review Comment:
Grammar: "uses of pyproject.toml" should be "use of pyproject.toml".
```suggestion
with the use of pyproject.toml) configuration of a driver build is now
declarative. All
```
##########
docs/upgrading.rst:
##########
@@ -4,9 +4,51 @@ Upgrading
.. toctree::
:maxdepth: 1
+Upgrading to 3.30.0
+-------------------
+Version 3.30.0 of the Python driver is the first release since the driver's
donation
+to the Apache Software Foundation (ASF).
+
+Supported Python Versions
+^^^^^^^^^^^^^^^^^^^^^^^^^
+An individual version of the Python driver aims to officially support all
Python runtimes
+that are not end-of-life (EOL) at the time of that versions release. For
3.30.0 this policy
+entails support for Python 3.10 through Python 3.14. The driver will likely
continue to work
+reasonably well on older Python runtimes but only these versions are
officially supported.
+
+Conversion to pyproject.toml
+^^^^^^^^^^^^^^^^^^^^^^^^^^^^
+With this release we are moving away from the install and configuration
process based on
+setup.py and towards the use of pyproject.toml. As a result of this change
(and in keeping
+with the uses of pyproject.toml) configuration of a driver build is now
declarative. All
+build options should be specified in pyproject.toml and overrides via
command-line flags or
+environment varaibles are no longer supported. Please consult
Review Comment:
Typo: "environment varaibles" is misspelled; should be "environment
variables".
```suggestion
environment variables are no longer supported. Please consult
```
##########
cassandra/connection.py:
##########
@@ -107,7 +107,7 @@ def decompress(byts):
return snappy.decompress(byts)
locally_supported_compressions['snappy'] = (snappy.compress, decompress)
-DRIVER_NAME, DRIVER_VERSION = 'DataStax Python Driver',
sys.modules['cassandra'].__version__
+DRIVER_NAME, DRIVER_VERSION = 'Apache Cassandra Python Driver',
sys.modules['cassandra'].__version__
Review Comment:
After changing STARTUP's DRIVER_NAME, the DataStax Insights payload still
hard-codes the old name (cassandra/datastax/insights/reporter.py:170 uses
"DataStax Python Driver"). If Insights is expected to reflect the same driver
identity change, this should be updated to match (or documented/justified if it
must remain DataStax-branded).
```suggestion
DRIVER_NAME = 'Apache Cassandra Python Driver'
cassandra_module = sys.modules.get('cassandra')
if cassandra_module is not None and hasattr(cassandra_module, '__version__'):
DRIVER_VERSION = cassandra_module.__version__
else:
DRIVER_VERSION = 'unknown'
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
