sunil9977 commented on code in PR #4222:
URL: https://github.com/apache/cassandra/pull/4222#discussion_r3015993599
##########
test/unit/org/apache/cassandra/utils/ASTGenerators.java:
##########
@@ -982,6 +1023,65 @@ else if (existAllowed)
};
}
+ private static final Gen<Conditional.Where.Inequality>
RANGE_INEQUALITY_GEN =
SourceDSL.arbitrary().pick(Conditional.Where.Inequality.GREATER_THAN_EQ,
+
Conditional.Where.Inequality.GREATER_THAN,
+
Conditional.Where.Inequality.LESS_THAN_EQ,
+
Conditional.Where.Inequality.LESS_THAN);
+
+ private static final Gen<Conditional.Where.Inequality> LOWER_BOUND_GEN
= SourceDSL.arbitrary().pick(Conditional.Where.Inequality.GREATER_THAN,
+
Conditional.Where.Inequality.GREATER_THAN_EQ);
+
+ private static final Gen<Conditional.Where.Inequality> UPPER_BOUND_GEN
= SourceDSL.arbitrary().pick(Conditional.Where.Inequality.LESS_THAN,
+
Conditional.Where.Inequality.LESS_THAN_EQ);
+
+
+ private void valueRange(RandomnessSource rnd,
+ Map<Symbol, ExpressionBuilder>
columnExpressions,
+ Conditional.ConditionalBuilder<?> builder,
+ LinkedHashSet<Symbol> columns,
+ @Nullable Gen <? extends Map<Symbol, Object>>
gen)
+ {
+ if (gen != null)
+ {
+ Map<Symbol, Object> lower = gen.generate(rnd);
Review Comment:
The `gen != null `path ensures range deletes work correctly when a caller
provides clustering value generators via `withClusterings()`. The (only) test
`testRangeDeleteGeneratorWithClusteringValueGen` exercises this path. Happy to
remove it if you'd prefer to keep it out of scope here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
