joao-r-reis commented on code in PR #1936:
URL:
https://github.com/apache/cassandra-gocql-driver/pull/1936#discussion_r2960725925
##########
frame.go:
##########
@@ -759,7 +759,11 @@ func (f *framer) parseErrorFrame() (frame, error) {
return nil, err
}
return res, nil
- case ErrCodeInvalid, ErrCodeBootstrapping, ErrCodeConfig,
ErrCodeCredentials, ErrCodeOverloaded,
+ case ErrCodeOverloaded:
+ return &RequestErrOverloaded{errorFrame: errD}, nil
+ case ErrCodeBootstrapping:
+ return &RequestErrBootstrapping{errorFrame: errD}, nil
+ case ErrCodeInvalid, ErrCodeConfig, ErrCodeCredentials,
ErrCodeProtocol, ErrCodeServer, ErrCodeSyntax, ErrCodeTruncate,
ErrCodeUnauthorized:
// TODO(zariel): we should have some distinct types for these
errors
Review Comment:
We want all of these to have their own types too but it's up to you if you
want to add these or if you want to keep this patch focused on overloaded and
bootstrapping, let me know
##########
CHANGELOG.md:
##########
@@ -9,6 +9,7 @@ and this project adheres to [Semantic
Versioning](https://semver.org/spec/v2.0.0
### Added
+- Add RequestErrOverloaded and RequestErrBootstrapping for dedicated error
handling (CASSGO-113)
Review Comment:
Very minor thing but can you move this to the bottom of the section just to
keep the order in which these patches were committed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
