On 10/17/20 11:34 AM, Wietse Venema wrote:
> Demi M. Obenour:
>> Should I submit another patch?  In addition to adding
>> local_sender_login_maps, I have fixed what appeared to be a bug in
>> the current postdrop and sendmail commands: root and $mail_owner were
>> not automatically allowed to submit mail.  Since this is inconsistent
>> with similar checks elsewhere, I believe it is unintentional.
> 
> No. I am working on a quality implementation, and that takes more
> time than 'code that works'. More patches are not needed.

Indeed it does.  If I may ask, is there any way I could have made my
patch better?  I would like to know so that I can write better code
in the future.

> BTW I realized that I swapped the semantics of smtpd_sender_login_maps
> (a mapping from sender address to the login names that are allowed
> to use that sender address) when we were discussing the postdrop
> feature (a mapping from login name to the sender addresses that the
> login name is allowed to use).
> 
> If we stick with that model, then I think that the feature should be
> renamed to local_login_sender_maps.

I agree, although I wonder if it is better to be consistent and
change the semantics to match those of smtpd_sender_login_maps.
local_login_sender_maps was easier to implement and seemed more
intuitive, but it is less consistent than local_sender_login_maps,
which can in some cases be set as

local_sender_login_maps = $smtpd_sender_login_maps

in main.cf.

>       Wietse

Demi

Attachment: OpenPGP_0xB288B55FFF9C22C1.asc
Description: application/pgp-keys

Attachment: OpenPGP_signature
Description: OpenPGP digital signature

Reply via email to